Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support apiEndpoint override #728

Merged
merged 3 commits into from
May 31, 2019
Merged

feat: support apiEndpoint override #728

merged 3 commits into from
May 31, 2019

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2019
@JustinBeckwith JustinBeckwith mentioned this pull request May 29, 2019
Closed
1 task
@codecov
Copy link

codecov bot commented May 29, 2019 •
edited
Loading

Codecov Report

Merging #728 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   96.77%   96.78%   +<.01%     
==========================================
  Files           9        9              
  Lines        1149     1150       +1     
  Branches      294      295       +1     
==========================================
+ Hits         1112     1113       +1     
  Misses          9        9              
  Partials       28       28
Impacted Files Coverage Δ
src/storage.ts 97.36% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f8a74...04b2122. Read the comment docs.

@codecov
Copy link

codecov bot commented May 29, 2019 •
edited
Loading

Codecov Report

Merging #728 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   96.79%   96.79%   +<.01%     
==========================================
  Files           9        9              
  Lines        1155     1156       +1     
  Branches      295      296       +1     
==========================================
+ Hits         1118     1119       +1     
  Misses          9        9              
  Partials       28       28
Impacted Files Coverage Δ
src/storage.ts 97.36% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988345d...9bc8b20. Read the comment docs.

@JustinBeckwith JustinBeckwith mentioned this pull request May 29, 2019
Closed
51 tasks
@stephenplusplus stephenplusplus merged commit 61eeb64 into master May 31, 2019
@stephenplusplus stephenplusplus deleted the apiendpoint branch November 26, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenplusplus stephenplusplus stephenplusplus approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

@bcoe bcoe Awaiting requested review from bcoe

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinBeckwith @stephenplusplus @googlebot